HaloMods "Classic" Read-only Archive

• The internalise code is pretty poor; it adds alls the new space that is needed in chunks, and then proceeds with overwriting that space with the bitmap raw. This way of doing things slows down the method, and will also consume more memory to get the job done.
• The way the padding for the bitmap LOD is calculated is not exactly sound. Yours/ants way will always work still, but once the bitmap raw becomes divisible exactly by 512, the method will return 512 (when it should be returning 0). This means you'll end up with 512 pointless bytes in your map.
  
  Here, I modified the method for you if you ever want to update the application:
  

  Code: Select all

          private int RoundTo512(int Value2Round)
          {
              int padding = 512 - (Value2Round % 512);
              if (padding == 512) padding = 0;
              return Value2Round + padding;
          }

• The internaliser doesn't use the map paths set by the user. If the bitmap raw is in an external map (which it will be of course 99% of the time), it will just look in the currently-opened-map's directory for them...andd thus you'll get an error if that is not where they are placed.

Prey wrote:Hey, Prodigy = Me

Prey wrote:The internalise code is pretty poor; it adds alls the new space that is needed in chunks, and then proceeds with overwriting that space with the bitmap raw. This way of doing things slows down the method, and will also consume more memory to get the job done.

Prey wrote:The way the padding for the bitmap LOD is calculated is not exactly sound. Yours/ants way will always work still, but once the bitmap raw becomes divisible exactly by 512, the method will return 512 (when it should be returning 0). This means you'll end up with 512 pointless bytes in your map.

Prey wrote: Here, I modified the method for you if you ever want to update the application:

Code: Select all

        private int RoundTo512(int Value2Round)
        {
            int padding = 512 - (Value2Round % 512);
            if (padding == 512) padding = 0;
            return Value2Round + padding;
        }

return ( 512 - ( Value2Round % 512 ) ) % 512;

Prey wrote:The internaliser doesn't use the map paths set by the user. If the bitmap raw is in an external map (which it will be of course 99% of the time), it will just look in the currently-opened-map's directory for them...andd thus you'll get an error if that is not where they are placed.

Prey wrote:Apart from all that though it looks good. I especially like the single-instance implementation, tis' a nice touch

OwnZ joO wrote:This is my edited version of the 1.3 source released to the public.

Features:

This feature has not been released publicly as far as I know - I made it have the ability to be a single instance application, this means that if you have entity open, and double click a map file from the windows explorer, it will open the map in that existing entity. This can be turned off in the settings.

Proper renaming, it's tricky though, as it forces you to rename it with a name the same size or smaller than the original.

Allows you to choose the name of meta when duplicating.

Bitmap internalizer - Anthony

Goto Tag function - Prey

Set map paths, and if they're not set/the map is not found, it will pop up an open file dialog asking to open the map

OwnZ joO wrote:I think I will update, and i'll do it in one line

Code: Select all

return ( 512 - ( Value2Round % 512 ) ) % 512;

return Value2Round + ( ( 512 - ( Value2Round % 512 ) ) % 512);

Prey wrote:That won't work. The code is fine, but you forgot that the method rounds the given value...here:

Code: Select all

return Value2Round + ( ( 512 - ( Value2Round % 512 ) ) % 512);

OwnZ joO wrote:

Code: Select all

return ( 512 - ( Value2Round % 512 ) ) % 512;

return Value2Round + (( 512 - ( Value2Round % 512 )) % 512));